Repository navigation
fix(server): avoid reusing an acquired reserved port - #5608
Merged
fatedier merged 1 commit intoNov 10, 2026
Merged
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-6.1-sol · Input: 36 · Output: 2.3K · Cached: 322.8K |
fatedier
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Fixes #5607.
A proxy reconnecting with
remotePort = 0could reclaim its previous port after another proxy acquired it but before that proxy bound its socket. The successful socket probe let the reconnect overwrite the active allocation.Check the manager's free-port set before probing the remembered port. If it has already been acquired, use the existing random allocation path. This preserves reuse when the previous port is free and leaves the other proxy's allocation intact.
Tests
devand pass with this change.go test -race ./server/ports -count=25go test -tags noweb ./assets/... ./cmd/... ./client/... ./server/... ./pkg/...make buildand both existingAlloc Random Portend-to-end specs (legacy and v1)